Got to agree with a lot of your picks especially Gary's, with Memorial Day Marathons going on Turner Classic Movies and American Movie Classics, I'm reminded of alot of great movies...and some real schlock.
Here's some more to add to the lists
The Wind and the Lion
Hell is for Heroes
Thirty Seconds Over Tokyo
Empire of the Sun
Young Winston
Hope and Glory
Henry V (Kenneth Branagh's version)
Abe Lincoln of Illinois
Gore Vidal's 'Lincoln'
The Crossing
Conspiracy
the German film the above is based on-Die Wanssee Konferenz
some "indie" flicks that don't get alot of attention
Ride With the Devil--ACW in MO/KS w/ Tobey Maquire, Simon Baker, Jeffrey Wright, Jewell,
Jonathan Rhys Meyer, Tom Wilkinson, etc. directed by Ang Lee
Ambrose Bierce: Civil War Stories--very "indie," well made, well acted with 'fit' re-enactors of military age, 2006 directed by Don Maxwell
Company K--2004, based on novelized memoir of William March a Marine veteran of Belleau Wood and the Argonne
Oh What a Lovely War--Richard Attenborough's directorial debut, a Great War Musical! All of the music is contemporary British music-hall and soldier songs ca.1914-18.
Speaking of musicals of historical events, to my knowlege the only movies ever made about the California Gold Rush and the conception, discussion and drafting of the Declaration of Independence are respectively " Paint Your Wagon," and "1776!"
And of course the all time greatest war movie...drumroll please....
THE SIEGE OF FIREBASE GLORIA!!!!
Cheers
EDIT--Sorry forgot to mention some of my 'worsts':
Spike Lee's Miracle of St. Anne...annoyingly bad
Indigenes--the star actor has only one arm thus the main character, the rebellious North African Colonial fighting both for France's honor and French racism, takes on Les Boche literally single-handedly with one empty sleeve jammed into his jacket pocket. I couldn't get past that.
Flyboys